nic firmware enhancements - #285
Open
jaspals3123 wants to merge 2 commits into
Open
jaspals3123 wants to merge 2 commits into
jaspals3123 wants to merge 2 commits into
Conversation
alexandraBara
requested changes
Sep 18, 2026
Comment on lines
+1
to
+5
| ############################################################################### | ||
| # | ||
| # MIT License | ||
| # | ||
| ############################################################################### |
Collaborator
There was a problem hiding this comment.
please add the correct license
|
|
||
|
|
||
| class NetworkAnalyzer(RegexAnalyzer[NetworkDataModel, None]): | ||
| def _validate_firmware_policy(records: list[Dict[str, Any]], policies: Any) -> list[Dict[str, Any]]: |
Collaborator
There was a problem hiding this comment.
this function along with _ploicy_matches and _normalize_firmware_version are all shared by network/nic/rdma analyzers. Please move them in utils or something like that so they can share it.
|
|
||
| def _firmware_matches(actual: str, expected_pattern: str) -> bool: | ||
| try: | ||
| return re.fullmatch(expected_pattern, actual, flags=re.IGNORECASE) is not None |
Collaborator
There was a problem hiding this comment.
i think u want to use re.escape instead of fullmatch here?
| ) | ||
| self._parse_ethtool_driver_info(ethtool_info, res_driver.stdout) | ||
| ethtool_data[iface.name] = ethtool_info | ||
|
|
Collaborator
There was a problem hiding this comment.
this should log a warning when ethtool -i cannot be collected for the interface, something like:
else:
self._log_event(
category=EventCategory.NETWORK,
description=(
f"Error collecting ethtool -i driver info for interface: {iface.name}"
),
data={
"command": res_driver.command,
"exit_code": res_driver.exit_code,
"stderr": res_driver.stderr,
},
priority=EventPriority.WARNING,
)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{ "name": "firmware policy", "plugins": { "RdmaPlugin": { "collection_args": {}, "analysis_args": { "expected_nic_firmware": "238.1.168.0" } }, "NicPlugin": { "collection_args": {}, "analysis_args": { "expected_nic_firmware": "238.1.169.0" } }, "NetworkPlugin": { "collection_args": {}, "analysis_args": { "expected_nic_firmware": "238.1.168.0" } } } }node-scraper --plugin-configs=/home/jaspals/node-scraper/rdma.json